fix: interpolated scripts couldn't contain single-quotes #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve the moperl function (no need for the previous bash quoting hack)
|
Sorry @gares for not merging this sooner 😅 - as the underlying function was a critical part of the parsing for the customizable fields of the action, I really wanted to back-up this change with more tests and ideally some automated tests. Now, with #60, Planning to do a point release (docker-coq-action v1.2.4) in a short while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
moperlfunction (no need for the previous bash quoting hack)@Zimmi48 I only did manual unit tests for now :) so I'll merge this and make a point release very soon, after I've done an e2e test.