-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pull $COQ_IMAGE
if it exists locally
#82
Conversation
This seems to break with
See https://github.com/mit-plv/fiat-crypto/actions/runs/3517325936/jobs/5894966269 and mit-plv/fiat-crypto#1517 |
(Recall that GHA follows a DooD architecture.) Close #80
46213c2
to
1e4f934
Compare
@JasonGross sorry, my bad… I had added this feature on top on a too-old master branch 😅 so I just rebased; |
Seems to build, at least: https://github.com/mit-plv/fiat-crypto/actions/runs/3517325936/jobs/5901070228 |
OK @JasonGross; unfortunately your run did not went through the second docker-coq-action call. Do you want that I wait for a second test of yours? or do you prefer that I just add a more thorough test (beyond the one below) then do a release? docker-coq-action/.github/workflows/python-demo.yml Lines 81 to 84 in 1e4f934
→ https://github.com/coq-community/docker-coq-action/actions/runs/3518557133/jobs/5897601262#step:3:299 |
OK @JasonGross so I pushed a more thorough test, and everything looks good to go: So let's release 1.4.1 now… |
Close #80