Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pull $COQ_IMAGE if it exists locally #82

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Nov 21, 2022

Close #80

@JasonGross
Copy link
Member

This seems to break with

  Error: No such image: coqorg/coq:dev-ocaml-default
  
  Error response from daemon: manifest for coqorg/coq:dev-ocaml-default not found: manifest unknown: manifest unknown

See https://github.com/mit-plv/fiat-crypto/actions/runs/3517325936/jobs/5894966269 and mit-plv/fiat-crypto#1517

@erikmd
Copy link
Member Author

erikmd commented Nov 21, 2022

@JasonGross sorry, my bad… I had added this feature on top on a too-old master branch 😅 so I just rebased;
could you please rerun your test PR?
Thanks again 👍👍

@JasonGross
Copy link
Member

@erikmd
Copy link
Member Author

erikmd commented Nov 22, 2022

OK @JasonGross; unfortunately your run did not went through the second docker-coq-action call.

Do you want that I wait for a second test of yours?

or do you prefer that I just add a more thorough test (beyond the one below) then do a release?

entrypoint: /bin/sh
# see also https://github.com/coq-community/docker-coq-action/issues/80#issuecomment-1321272915
# args: -c "/bin/echo \"${{ secrets.GITHUB_TOKEN }}\" | docker login ${{ env.REGISTRY }} -u ${{ github.actor }} --password-stdin && exec /app/entrypoint.sh \"$@\"" sh
args: -c "docker pull ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.IMAGE_TAG }} && exec /app/entrypoint.sh \"$@\"" sh

https://github.com/coq-community/docker-coq-action/actions/runs/3518557133/jobs/5897601262#step:3:299

@erikmd
Copy link
Member Author

erikmd commented Nov 24, 2022

OK @JasonGross so I pushed a more thorough test, and everything looks good to go:

https://github.com/coq-community/docker-coq-action/actions/runs/3536674876/jobs/5935937276#step:5:208

So let's release 1.4.1 now…

@erikmd erikmd merged commit 56a68e2 into master Nov 24, 2022
@erikmd erikmd deleted the pull-if-missing branch November 24, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to ensure a single Coq version is used across multiple invocations of the action
2 participants