Fix exit train w/ memory test but without setting any limit #2200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting limit to 0 for
train_impl
, we can keep the memory test without encountering #2195 making #2199 obsolete.See the logs for the test: https://gist.github.com/wasertech/7274eee6e6d9a599920949788b248bbf
We need to fix this parameter so it doesn't prevent the exit of the process.