Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webrtcvad by silero-vad #1431

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Replace webrtcvad by silero-vad #1431

merged 3 commits into from
Mar 24, 2022

Conversation

Edresson
Copy link
Contributor

@Edresson Edresson commented Mar 22, 2022

Advantages of the new script against the old one:

  1. Better quality in trimming nonspeech parts.
  2. Support to all sample rates (I'm using the 8khz Silero-VAD model and just mapping the time stamps between all possible sample rates >= 8Khz).
  3. Now is possible to trim just the beginning and end of the audio (parameter --trim_just_beginning_and_end)

@erogol
Copy link
Member

erogol commented Mar 23, 2022

Is there a test for it?

Also I guess you need to rebase for the checks

@Edresson
Copy link
Contributor Author

Is there a test for it?

Also I guess you need to rebase for the checks

The test is already implemented in tests/aux_tests/test_remove_silence_vad_script.py. Given that the old script and the new one have basically the same params we don't need to change it :). I will rebase it.

@Edresson Edresson merged commit 464dc65 into dev Mar 24, 2022
@erogol erogol deleted the silero-vad branch March 24, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants