Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing CLI revamp [WIP] #1686

Closed
wants to merge 10 commits into from
Closed

Introducing CLI revamp [WIP] #1686

wants to merge 10 commits into from

Conversation

p0p4k
Copy link
Contributor

@p0p4k p0p4k commented Jun 23, 2022

I found TTS command line interface to be slightly un-intuitive ; be it typing complete model names OR re-loading models for every "--text" run even on the same model. On top of it, typing --"parameter" "value" seems so outdated. So, just to spice some things up, introducing a better and modern CLI.

image
image

  • It is a WIP.

  • Based on python-inquirer package.

  • My plan is to add all the features from existing CLI (with the help of synthesize.py).

  • Supports holding the loaded model in memory to avoid re-loading it again unless "tts restarted".
    image

  • Supports changing speaker_idx and other multi-speaker params for the same loaded model without re-loading it.

  • Added tqdm progress bar for model downloads based on feature request [Feature request] add progress bar for model downloads #1530 .
    image

  • Added model info support
    image

  • Gonna update the description as I add more features.

  • Please comment if you have any new features in your mind.

Known bugs :

  • arrow keys do not work for windows. current fix: Use num-pad arrow keys instead (num lock OFF).
    proper fix:The python-inquirer repo has a PR for windows fix, waiting for merge.

@p0p4k
Copy link
Contributor Author

p0p4k commented Jun 24, 2022

On side note, I have tested below config on python=3.10, pytorch=1.11, torchaudio=0.11.0 and works well with no errors.
Due to recent bump in numpy errors while installing TTS, I believe we need to rectify this ASAP. I might need some help with testing this configuration. Thanks.

# core deps
numpy==1.21.6;python_version<"3.10"
numpy==1.22.4;python_version=="3.10"
numba==0.55.1;python_version<"3.10"
numba==0.55.2;python_version=="3.10"
#deps for CLI
inquirer

@Cube707
Copy link

Cube707 commented Jul 5, 2022

FYI: The readchar libary that handles the userinput for python-inquirer is currently broken on both windows and Unix. I recomend pinning it to readchar!=3.0.5, that way at least the unix side should work and it gets updated once the author gets back to me..

I also moved the development to a fresh PR, spliting it into magmax/python-readchar#76 and magmax/python-readchar#79

@Cube707
Copy link

Cube707 commented Jul 30, 2022

another FYI: I am now a colaborator on readchar and was able to merge the fixes. Since the new v3.0.6 the arrow keys should be properly supported on windows.

Also a new Version v4.0.0 is currently in pre-releaes. It change quites a bit about the libary so maybe consier it in your development (or even give feedback if you find bugs in it..)

@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Aug 31, 2022
@stale stale bot closed this Sep 7, 2022
@erogol
Copy link
Member

erogol commented Sep 8, 2022

@p0p4k do you plan to continue this PR or should I leave it closed?

@p0p4k
Copy link
Contributor Author

p0p4k commented Sep 8, 2022

I will continue it after 2 weeks. Can I reopen it later on?

@erogol
Copy link
Member

erogol commented Sep 8, 2022

Sure, I reopen now... Thanks for the update

@erogol erogol reopened this Sep 8, 2022
@stale stale bot removed wontfix This will not be worked on but feel free to help. labels Sep 8, 2022
@stale
Copy link

stale bot commented Oct 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Oct 8, 2022
@p0p4k
Copy link
Contributor Author

p0p4k commented Oct 8, 2022

10/08/2022 : Closing now. Will open when I get some free time.

@p0p4k p0p4k closed this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on but feel free to help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants