-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft ONNX export for VITS #2563
Conversation
Could not get it work to output variable length sequence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good to me.
@NeonBohdan can you give me sample code to reproduce? |
@erogol sure Got |
@NeonBohdan can you post the code here in the thread? I don't want to download a file that I don't know. |
With this model
|
I think your file has discriminator layers but config sets discriminator false. I could not reproduce the issue with default settings. |
I don't know Eren Golge. This sucker needs to do a better job. Let him know. Which model is this? What's the name? |
No problem, maybe the line With this model was lost previously |
Hi @erogol, thank you for this PR, it's saving me lot of time, could it be used also with Multi Speaker YourTTS?
Thank you |
@alessandropettenuzzo96 in code comment listed in this PR mentioned that it's only for single speaker models for now |
Did you get it working? I have the same issue |
@erogol Onnx inference is 6-7 times slower than Pytorch due to EXHAUSTIVE convolution search on cuDNN, which is the default mode in OnnxRuntime when simply Can you change from With DEFAULT as cudnn_conv_algo_search, OnnxRuntime performs ~20% better than the standard VITS Pytorch mode. This performance issue is detailed on microsoft/onnxruntime#12880 (comment) Thanks, Javier. |
If anyone else is in this situation, then changing vits.py file on line 1771 to this:
worked for me (recommended in discord by Jpg#0419) . And also make sure that you have |
@erogol |
@alessandropettenuzzo96 hello, have you solved this? I encountered the same problem. |
* Draft ONNX export for VITS Could not get it work to output variable length sequence * Fixup for onnx constant output * Make style * Remove commented code
Could not get it to output the variable length sequence. Dynamic shapes do not work for some reason. If anyone knows how, feel free to jump in.Thanks to @manmay-nakhashi I fixed the issue.
This is how it works