Bug: self.model_name needed to be initialized. #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: self.model_name needed to be initialize to get around a bug that automatically crashes when the user provides the model paths but no model_name when initializing the TTS object.
|
|
|
@vltmedia you wanna sign the CLA? |
|
@erogol Yeah am down to sign it, where can I? |
|
@vltmedia you can do it above where it says CLA not signed yet. |
|
@erogol sorry it took a while, just signed. The CLA badge/component wasn't rendering on my PCs, had to use my phone for it to render and be clickable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: self.model_name needed to be initialize to get around a bug that automatically crashes when the user provides the model paths but no model_name when initializing the TTS object. It literally just needs to be an empty string.
The error when no model_name was provided, only local cached models and config paths.