Misjudgment of is_multi_lingual
When Loading Multilingual Model via model_path
#3273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
first problem-without model_name
The logic in api.py to sentence a model whether is multi-lingual or not is through
model_name
.TTS/TTS/api.py
Lines 109 to 110 in 29dede2
second problem-with model_name
but the problem is if the model_name is given then the ModelManager will try to download the model to the output_prefix, which is default to
/home/yhtao/.local/share/tts
in my system.TTS/TTS/utils/generic_utils.py
Lines 129 to 148 in 29dede2
of course, there is no model under
/home/yhtao/.local/share/tts
, and then the ModelManager re-download model to this path.TTS/TTS/utils/manage.py
Lines 378 to 402 in 29dede2
Usage