Fix CI (save best model after 0 steps in tests) #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eginhard
force-pushed
the
fix-aux-tests
branch
from
9721ea7 to
99fee6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only saving the best model after N steps was enabled in coqui-ai/Trainer@c77173d. N defaults to 10000, breaking TTS tests: https://github.com/coqui-ai/Trainer/blob/bc68b2a17faf30e88a74f22a5731154f491f5765/trainer/trainer.py#L138
Here I set that value to 0 for the tests.
Also changed TTS/bin/train_encoder.py to use a dictionary for the loss to be consistent with the changes in Trainer 0.0.35