Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI (save best model after 0 steps in tests) #3423

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

eginhard
Copy link
Contributor

Only saving the best model after N steps was enabled in coqui-ai/Trainer@c77173d. N defaults to 10000, breaking TTS tests: https://github.com/coqui-ai/Trainer/blob/bc68b2a17faf30e88a74f22a5731154f491f5765/trainer/trainer.py#L138

Here I set that value to 0 for the tests.

Also changed TTS/bin/train_encoder.py to use a dictionary for the loss to be consistent with the changes in Trainer 0.0.35

@erogol erogol merged commit 55c7063 into coqui-ai:dev Dec 14, 2023
49 checks passed
@eginhard eginhard deleted the fix-aux-tests branch December 18, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants