Optional silence trimming during inference and find_endpoint() fix #898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
find_endpoint()
from theconfig.json
file anddo_trim_silence
is set toTrue
orFalse
. I am understanding the value is mostly there for training and removing lead/trail silences during preprocessing, but I feel it fits here also (we can anyway change this before inference).For
find_endpoint()
, I am a bit skeptical about whether that value should be set to e.g.-20dB
more than whattrim_db
is (to make it more robust). Please tell me what you think about this idea, or whether it should be the same.