Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional silence trimming during inference and find_endpoint() fix #898

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Optional silence trimming during inference and find_endpoint() fix #898

merged 3 commits into from
Oct 29, 2021

Conversation

george-roussos
Copy link
Contributor

@george-roussos george-roussos commented Oct 29, 2021

This commit:

  1. grabs the threshold db for find_endpoint() from the config.json file and
  2. makes silence trimming optional during inference, by checking whether do_trim_silence is set to True or False. I am understanding the value is mostly there for training and removing lead/trail silences during preprocessing, but I feel it fits here also (we can anyway change this before inference).

For find_endpoint(), I am a bit skeptical about whether that value should be set to e.g. -20dB more than what trim_db is (to make it more robust). Please tell me what you think about this idea, or whether it should be the same.

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2021

CLA assistant check
All committers have signed the CLA.

@george-roussos george-roussos changed the title Dev Optional silence trimming during inference and find_endpoint() fix Oct 29, 2021
@erogol erogol merged commit 37eaefc into coqui-ai:dev Oct 29, 2021
@george-roussos george-roussos deleted the dev branch October 29, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants