Correct broken mysql_query (Pr/71 on old resources module) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPoulain
changed the title
|
Can't duplicate the issue with the master branch in the PHP 5.4.40 environment whereas this PR 71 does not produce new problem either in the same PHP 5.4.40 environment. |
|
We need to remove this "mysql_query" function because the PHP mysql API is deprecated in PHP 5.5 (now the oldest supported version) and is fully removed from PHP 7.0 (released 5 months ago). For lots more details, see http://stackoverflow.com/questions/12859942/why-shouldnt-i-use-mysql-functions-in-php. |
Closed
jeffnm
pushed a commit
that referenced
this pull request
Jan 20, 2017
Fix issue of admin user being inserted into auth db when ldap enabled (solves related todo)
This was referenced Jun 13, 2017
jeffnm
pushed a commit
that referenced
this pull request
Apr 4, 2018
PHP message: PHP Fatal error: Uncaught Exception: There was a problem with the database: Expression #5 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'coral_organizations.OHP.parentOrganizationID' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by in /var/www/coral/organizations/admin/classes/common/DBService.php:39 Stack trace: #0 /var/www/coral/organizations/admin/classes/common/DBService.php(71): DBService->checkForError() #1 /var/www/coral/organizations/admin/classes/domain/Organization.php(550): DBService->processQuery('SELECT O.organi...', 'assoc') #2 /var/www/coral/organizations/ajax_htmldata.php(895): Organization->search(Array, 'TRIM(LEADING 'T...', '') #3 {main} thrown in /var/www/coral/organizations/admin/classes/common/DBService.php on line 39
jeffnm
pushed a commit
that referenced
this pull request
Apr 4, 2018
The “Starts with” letter list was not working… Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'coral_organizations.O.name' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to install this module, I am getting the error "Fatal error: Call to undefined function mysql_query() in /var/www/html/resources/install/install.php on line 64"
I suspect this was broken by 26ae17c which changes a lot of mysql_query calls, and also the commit message says "not yet tested"