Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SirsiDynix Issues: Emails not sent to organizational contacts #315

Conversation

queryluke
Copy link
Contributor

There were 2 problems:

  1. organizationContactsArray() was not an available method on the Resource class
  2. $email was not in the foreach loop

@t4k
Copy link
Contributor

t4k commented Oct 25, 2017

Can you lay out a test procedure so we can make sure this is working as expected?

@queryluke
Copy link
Contributor Author

Sure thing.

@queryluke
Copy link
Contributor Author

Sorry, did you mean a manual test procedure (found below) or an automated test?

REVIEW PROCEDURE

  1. Choose or make a resource to test, e.g. Test Resource 1
  2. In the Organizations module, add a test contact to the vendor of Test Resource 1. Make sure the contact has an email address that you can access.
  3. In the Resources module, select Test Resource 1 > Issues > Report New Issue
  4. Select the test contact, add a subject and body
  5. Submit the Issue
  6. The test contact should receive an email with the subject and body.

@t4k
Copy link
Contributor

t4k commented Oct 27, 2017

Manual is great for now! I and others are actively working on getting our automated test framework working and easy to use for everyone. Eventually we’ll want to require tests for all new and fixed functionality.

@PaulPoulain PaulPoulain added the bug This is a bug (not an enhancement) label Dec 12, 2017
@veggiematts
Copy link
Contributor

Could you resolve the conflicts, please?

…ue-creation-emails-not-sent

fixes merge conflicts with upstream/development
@queryluke
Copy link
Contributor Author

@veggiematts done.

@cjc66 cjc66 added the important Not critical but should be addressed label Mar 22, 2018
@cjc66 cjc66 added this to the Version 3.0.0 Beta milestone Mar 22, 2018
@@ -83,12 +83,12 @@
unset($newIssueContact);
}

$organizationContactsArray = $sourceResource->organizationContactsArray($sourceOrganizationID);
$organizationContactsArray = $sourceResource->getUnarchivedContacts();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getUnarchivedContacts is now a ResourceAcquisition method.
Use:
$organizationContactsArray = $sourceResourceAcquisition->getUnarchivedContacts();

@veggiematts veggiematts merged commit dbbb8bb into coral-erm:development Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug (not an enhancement) important Not critical but should be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants