-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SirsiDynix Issues: Emails not sent to organizational contacts #315
SirsiDynix Issues: Emails not sent to organizational contacts #315
Conversation
Can you lay out a test procedure so we can make sure this is working as expected? |
Sure thing. |
Sorry, did you mean a manual test procedure (found below) or an automated test? REVIEW PROCEDURE
|
Manual is great for now! I and others are actively working on getting our automated test framework working and easy to use for everyone. Eventually we’ll want to require tests for all new and fixed functionality. |
Could you resolve the conflicts, please? |
…ue-creation-emails-not-sent fixes merge conflicts with upstream/development
@veggiematts done. |
@@ -83,12 +83,12 @@ | |||
unset($newIssueContact); | |||
} | |||
|
|||
$organizationContactsArray = $sourceResource->organizationContactsArray($sourceOrganizationID); | |||
$organizationContactsArray = $sourceResource->getUnarchivedContacts(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getUnarchivedContacts is now a ResourceAcquisition method.
Use:
$organizationContactsArray = $sourceResourceAcquisition->getUnarchivedContacts();
There were 2 problems:
organizationContactsArray()
was not an available method on the Resource class$email
was not in the foreach loop