Issue 592: Import tool: detailed subjects #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows to define detailed subjets columns for the import tool. - Detailed subjects are not created: only existing detailed subjects are processed. - If the given detailed subject belongs to one or more general subjects, all the general subject/detailed subject couples are attached to the resource. Expected behavior/test plan: - Import with an existing general subject: the resource is created with the general subject - Import with an existing detailed subject: the resource is created with the general/detailed subjects couples - Import with a non existing detailed subject: the resource is created, the detailed subject is not created - Import with a non existing general subject: the resource is created with the general subject
|
Tested, and was unable to import any detailed subjects. Using an existing detailed subject (where the subject is one only one word, i.e. no black space) gives no warning but does not create any detailed subject on the imported record. Trying to add a detailed subject not existing or one with several words (like my first test subject: "Detailed test") gives a warning: A proper warning to the end-user should preferably be added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: issue #592 : Currently, only general subjects can be imported with the import tool. It would be nice to be able to import detailed subjects as well.
This patch allows to define detailed subjets columns for the import tool.
Because detailed subjects cannot be attached to a resource without a general subject, detailed subjects are not created: only existing detailed subjects are processed.
If the given detailed subject belongs to one or more general subjects, all
the general subject/detailed subject couples are attached to the resource.
Expected behavior/test plan: