Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts: Fix browser detection #1233

Merged
merged 2 commits into from
May 4, 2022
Merged

ts: Fix browser detection #1233

merged 2 commits into from
May 4, 2022

Conversation

aximili-dev
Copy link
Contributor

@aximili-dev aximili-dev commented Jan 4, 2022 •
edited
Loading

Relevant issue: #1232

@aximili-dev
Copy link
Contributor Author

After some thought I decided it might be better to just make the variable name a bit less generic, to still allow modifying the isBrowser setting from the environment.

@archseer
Copy link
Contributor

archseer commented Jan 6, 2022

Relevant issue seems to link to itself

@aximili-dev
Copy link
Contributor Author

@archseer Fixed the self link.

I closed my issue because it's basically the same as #1145, this pull request would fix that one too.

@archseer archseer mentioned this pull request Jan 10, 2022
Merged
@artlogic
Copy link

artlogic commented May 4, 2022

I just ran up against this issue myself - any chance this could get merged?

@armaniferrante armaniferrante merged commit 8ddc9f2 into coral-xyz:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aximili-dev @archseer @artlogic @armaniferrante