lang: Handle const array size casting and add const array size support for events #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlinton
changed the title
tomlinton
changed the title
paul-schaaf
reviewed
Mar 10, 2022
lang/syn/src/idl/file.rs
Outdated
| _ => false, | ||
| }) { | ||
| let size_string = format!("{}]", &constant.ident.to_string()); | ||
| let cast_size_string = format!("{} as usize]", &constant.ident.to_string()); |
There was a problem hiding this comment.
wdyt about removing the whitespace here and in tts_string and then comparing those instead? would really suck to debug an error that's caused by an additional whitespace between as and usize
There was a problem hiding this comment.
No sympathy for people who don't use code formatters. 😈
I think it's an unlikely case but I'll add it if you like. Regex would probably have fewer edge cases but adding that seems a bit over the top.
There was a problem hiding this comment.
some people run their formatters before they commit and not during coding. still unlikely that it even happens but doesnt hurt to add it
agree that regex seems over the top
paul-schaaf
approved these changes
Mar 11, 2022
|
tyvm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1476
Closes #1357