Add support for idl enum tuples, enchance types #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devDesu
commented
Sep 15, 2022
devDesu
commented
- Recursive types decoding
- Correct enum types decoding
- IdlEvents type
- Recursive types decoding - Correct enum types decoding - IdlEvents type
|
Someone is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
devDesu
force-pushed
the
ts-types-enchantments
branch
from
71aa371
to
9077d29
Compare
|
@armaniferrante please take a look at the PR |
|
Resolves issue #2050 |
|
Ping @armaniferrante |
|
This would be very useful!! +1 |
|
We're stuck with 0.24.2 because of a regression in 0.25.0 that this should resolve. Would be nice to see this merged. |
|
This is very helpful! This would also make the |
|
I don't feel fully qualified to review the PR but it looks safe enough.
It's adding some extra functionality to the IDL type stuff and it has
tests. I'll try to take a deeper look at it tomorrow.
…On Mon, Oct 10, 2022, 6:31 PM Totoro ***@***.***> wrote:
Ping @ChewingGlass <https://github.com/ChewingGlass> @Henry-E
<https://github.com/Henry-E> @armaniferrante
<https://github.com/armaniferrante>
—
Reply to this email directly, view it on GitHub
<#2185 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADAHMGFSE2BYKR2OVSC7W43WCRHFPANCNFSM6AAAAAAQNKZYYE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks @devDesu for your persistence! |
Henry-E
pushed a commit
to Henry-E/anchor
that referenced
this pull request
Dec 6, 2022
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.