-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lang: add the InitSpace macro #2346
Conversation
@Aursen is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
@Henry-E What do you want for the name of the macro? InitSpace, MaxSpace, Space or other? |
The Aside from the failing tests, is the PR feature complete now in your opinion? |
I think so, I hope I haven't missed anything. |
This looks good but we should give it a doc string similar to what the other macros have and maybe reference somewhere in the rest of the rust docs. I will look into adding this maybe. Edit: Actually no, I see the doc string above the derive |
@Henry-E I added a test and fixed the issue normally |
@Aursen final thing is just to add a changelog surfacing the new macro! |
Thanks for the great work! |
Adds a new macro to automatically calculate the space.
What remains to be done is: