-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lang: Make stack frames slimmer on ATA creation #3065
lang: Make stack frames slimmer on ATA creation #3065
Conversation
@andreisilviudragnea is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an area we'd like to improve, so thank you for the PR!
Please see the comments.
1ae4f51
to
4d868c1
Compare
4d868c1
to
6e1e445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks!
@acheroncrypto When will a new Anchor version be released? This fix is quite important for me. |
Not sure, but we might need to make a patch release depending on the resolution of #3044. Do you publish your crates? If not, you can just depend on the |
@acheroncrypto When approximately will a new Anchor version be released? Depending on git versions for dependencies can sometimes be seen as an unsafe habit. I see there is very active development on master branch, so I expect it to take some time. |
~3 weeks
This PR was merged slightly after the last release, so there won't be many changes if you depend on this PR's commit hash |
Initializing many associated token accounts in the same instruction can result in too large stack frames at compile time:
The problem has been fixed similar to #2913 by inlining local variables created while generating associated token account creation code.