Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Skip IDL checks if --no-idl option is passed #3093

Merged
merged 3 commits into from
Jul 19, 2024
Merged

cli: Skip IDL checks if --no-idl option is passed #3093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d001002
cli: Skip IDL checks if `--no-idl` option is passed
acheroncrypto Jul 19, 2024
98a47dc
cli: Add the IDL checks to the `idl build` command
acheroncrypto Jul 19, 2024
c3dd9c8
Update CHANGELOG
acheroncrypto Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The minor version will be incremented upon a breaking change and the patch versi
- lang: Make `InitSpace` support unnamed & unit structs ([#3084](https://github.com/coral-xyz/anchor/pull/3084)).
- lang: Fix using `owner` constraint with `Box`ed accounts ([#3087](https://github.com/coral-xyz/anchor/pull/3087)).
- lang: Add a sanity check for unimplemented token extensions ([#3090](https://github.com/coral-xyz/anchor/pull/3090)).
- cli: Skip IDL checks if `--no-idl` option is passed ([#3093](https://github.com/coral-xyz/anchor/pull/3093)).

### Breaking

Expand Down
5 changes: 3 additions & 2 deletions cli/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1819,8 +1819,6 @@ fn _build_rust_cwd(
arch: &ProgramArch,
cargo_args: Vec<String>,
) -> Result<()> {
check_idl_build_feature().ok();

let exit = std::process::Command::new("cargo")
.arg(arch.build_subcommand())
.args(cargo_args.clone())
Expand Down Expand Up @@ -2683,6 +2681,7 @@ fn idl_build(
.path
}
};
check_idl_build_feature().ok();
let idl = anchor_lang_idl::build::build_idl_with_cargo_args(
program_path,
cfg.features.resolution,
Expand Down Expand Up @@ -2735,6 +2734,8 @@ in `{path}`."#
));
}

check_idl_build_feature().ok();

anchor_lang_idl::build::build_idl_with_cargo_args(
std::env::current_dir()?,
cfg.features.resolution,
Expand Down
Loading