-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce OpenTelemetry Integration chart #258
Merged
matej-g
merged 14 commits into
coralogix:master
from
matej-g:introduce-otel-integration-chart
Jul 27, 2023
Merged
Introduce OpenTelemetry Integration chart #258
matej-g
merged 14 commits into
coralogix:master
from
matej-g:introduce-otel-integration-chart
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
force-pushed
the
introduce-otel-integration-chart
branch
2 times, most recently
from
July 24, 2023 10:27
0a00162
to
da93b1d
Compare
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
force-pushed
the
introduce-otel-integration-chart
branch
from
July 24, 2023 10:55
da93b1d
to
246e9bd
Compare
matej-g
requested review from
avivgold098,
ShauliSolomovich,
povilasv,
oded-dd and
nicolastakashi
as code owners
July 24, 2023 10:58
povilasv
reviewed
Jul 24, 2023
povilasv
reviewed
Jul 24, 2023
povilasv
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, other than that LGTM
Signed-off-by: Matej Gera <matejgera@gmail.com>
povilasv
approved these changes
Jul 25, 2023
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
povilasv
approved these changes
Jul 27, 2023
nicolastakashi
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves ES-55.
This PR introduces a new chart called OpenTelemetry Integration part, that combines functionalities of both agent and the infrastructure collector (+ collects metrics for K8s dashboard out of the box). Includes as well CI changes and detailed documentation. For more details see the ticket description.
How Has This Been Tested?
Checklist: