Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-integration] feat support host.id from system resource detector #280

Merged
merged 1 commit into from
Aug 21, 2023
Merged

[otel-integration] feat support host.id from system resource detector #280

merged 1 commit into from
Aug 21, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Aug 21, 2023 •
edited
Loading

Description

For bare-metal use case we don't have host.id, which is required for k8s dashboard. The host.id is only coming from gcp / aws detectors. This PR changes to use the system detector's host.id detection.

Fixes #ES-70

How Has This Been Tested?

  • installed on kind cluster

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review August 21, 2023 13:29
matej-g
matej-g approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 🙇

@povilasv povilasv merged commit 355d3b3 into master Aug 21, 2023
3 checks passed
@povilasv povilasv deleted the host-id-fix branch August 21, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @matej-g