Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-integration] set cluster name for all signals #289

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[otel-integration] set cluster name for all signals #289

merged 1 commit into from
Sep 15, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Sep 15, 2023 •
edited
Loading

Description

Use metadata preset to push k8s.cluster.name for all signals

Fixes ES-93, CDS-631.

How Has This Been Tested?

Tested on kind cluster and checked k8s dashboard

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv force-pushed the add-cluster-name-for-all-signals branch from 9f8e9b9 to 4a62f6e Compare September 15, 2023 11:56
@povilasv povilasv marked this pull request as ready for review September 15, 2023 11:59
matej-g
matej-g approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@povilasv povilasv merged commit 21e172f into master Sep 15, 2023
4 of 5 checks passed
@povilasv povilasv deleted the add-cluster-name-for-all-signals branch September 15, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @matej-g