Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-integration] fix logs collection force flush period #390

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[otel-integration] fix logs collection force flush period #390

merged 1 commit into from
Mar 20, 2024

Conversation

povilasv
Copy link
Contributor

Description

Fixes logsCollection preset to make force flush period configureable, and disable it by default since it causes splitting log issue.

Fixes ES-224

How Has This Been Tested?

kind

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review March 19, 2024 16:22
royfur
royfur approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@royfur royfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povilasv povilasv merged commit 29cc18c into master Mar 20, 2024
7 checks passed
@povilasv povilasv deleted the force-flush branch March 20, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royfur royfur royfur approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@matej-g matej-g Awaiting requested review from matej-g

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @royfur