Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search webhooks by name #271

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Search webhooks by name #271

merged 1 commit into from
Sep 18, 2024

Conversation

assafad1
Copy link
Contributor

@assafad1 assafad1 commented Sep 16, 2024 •
edited
Loading

Description

Currently, it is supported to search a webhook only by its ID. This PR adds an option to search a webhook by its name.

Notes:

  • Using both ID and name together will raise an error.
  • Currently, the provider raises an error in case there are multiple webhooks with the given name.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@assafad1 assafad1 force-pushed the IAC-192 branch 13 times, most recently from 4af02be to a16f257 Compare September 16, 2024 14:03
@assafad1 assafad1 marked this pull request as ready for review September 16, 2024 15:04
@assafad1 assafad1 requested a review from a team as a code owner September 16, 2024 15:04
@assafad1 assafad1 force-pushed the IAC-192 branch 5 times, most recently from 46f3d0d to 8ef27f4 Compare September 17, 2024 09:47
@assafad1 assafad1 requested a review from a team as a code owner September 18, 2024 07:13
@assafad1 assafad1 merged commit 4f6c719 into coralogix:master Sep 18, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celaus celaus celaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@assafad1 @CLAassistant @celaus