Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix geoip enrichments client #298

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix geoip enrichments client #298

merged 1 commit into from
Dec 9, 2024

Conversation

lootag
Copy link
Contributor

@lootag lootag commented Dec 6, 2024 •
edited
Loading

Description

The enrichments were not being filtered properly in the client: geo enrichments now have the WithAsn field, so the previous string match didn't match any geoIp enrichments.

@lootag lootag requested a review from a team as a code owner December 6, 2024 20:16
@celaus
Copy link
Contributor

celaus commented Dec 9, 2024 

=== RUN   TestAccCoralogixDataSourceEnrichment_basic
    data_source_coralogix_enrichment_test.go:27: Step 1/1 error: Check failed: Check 2/2 error: data.coralogix_enrichment.test: Attribute 'geo_ip.0.fields.0.name' expected "coralogix.metadata.sdkId", got "coralogix.metadata.IPAddress"

@lootag lootag merged commit 754f541 into master Dec 9, 2024
6 of 7 checks passed
@lootag lootag deleted the IAC-358 branch December 9, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celaus celaus celaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lootag @celaus