Bring re2 tinygo wasm binaries into this repo #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcchavezs @M4tteoP I have cut a new release of go-re2 that requires this change, until it you won't be able to use the latest version of go-re2 for coraza-proxy-wasm, which may not be a big deal anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am finally updating go-re2 to the latest version of Google re2 and because re2 has changed its build system significantly, notably depending on absl, it is not possible to build without threads anymore which breaks TinyGo / Envoy compatibility. I have removed building of the artifacts from the go-re2 project
https://github.com/wasilibs/go-re2?tab=readme-ov-file#tinygo
I have still left in a few
tinygo.wasmbuild tags to still allow the library to work if the Wasm files are provided as cgo flags so I have done that here to prevent coraza-proxy-wasm from breaking.It also raises the go version to 1.21 which is the minimum of the new go-re2 commit being used and probably matches coraza. I notice the change in #18 raising to 1.22 but I went minimally for this PR whose only goal is to bring in the Wasm binaries.