CORE-13858 - Record inbound message rate in the loopback case #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 3962 build 5 Build Successful: |
dimosr
requested review from
mnesbit,
driessamyn,
ronanbrowne,
rick-r3,
fenryka and
yarivus
as code owners
charlieR3
previously approved these changes
May 26, 2023
charlieR3
approved these changes
May 30, 2023
driessamyn
approved these changes
May 30, 2023
dimosr
deleted the
CORE-13858-add-inbound-delivery-metrics-for-loopback-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record inbound message rate for the loopback case as well (i.e. when destination is locally hosted within the same cluster). I also adjusted the code to populate all the tags for that metric in all cases, because otherwise the metric is not exported because the prometheus client used by micrometer requires the same set of tags to be populated for a specific metric name when within the same process (see discussion here).
Tested the change by deploying a single cluster and driving load between two virtual nodes in the same cluster using the
app-simulator.