Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-19282 wrap the mediator subscriptions client state in a MediatorState wrapper object #5418

Merged
merged 12 commits into from
Jan 15, 2024

Conversation

LWogan
Copy link
Contributor

@LWogan LWogan commented Jan 11, 2024

API: corda/corda-api#1442

New MediatorState wrapper allows us to store a list of bus bound output events per consumer input event.

A hash of ConsumerRecords (e.g Key + FlowEvent) will be used as the key to store bus bound output records of the message processor. e.g SessionEvents/FlowStatus. These will be stored in a follow-up PR.

This PRs scope is to introduce the wrapper MediaterState

@LWogan LWogan marked this pull request as ready for review January 11, 2024 15:43
@LWogan LWogan requested a review from a team as a code owner January 11, 2024 15:43
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jan 12, 2024

Jenkins build for PR 5418 build 12

Build Successful:
Jar artifact version produced by this PR: 5.2.0.0-alpha-1705334925626
Helm chart version produced by this PR: 5.2.0-alpha.1705334925626
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-5418/corda

…mediator-wrapper-state

# Conflicts:
#	libs/messaging/messaging-impl/src/main/kotlin/net/corda/messaging/mediator/StateManagerHelper.kt
#	libs/messaging/messaging-impl/src/main/kotlin/net/corda/messaging/mediator/factory/MediatorComponentFactory.kt
#	libs/messaging/messaging-impl/src/main/kotlin/net/corda/messaging/mediator/factory/MultiSourceEventMediatorFactoryImpl.kt
#	libs/messaging/messaging-impl/src/main/kotlin/net/corda/messaging/mediator/processor/ConsumerProcessor.kt
#	libs/messaging/messaging-impl/src/main/kotlin/net/corda/messaging/mediator/processor/EventProcessor.kt
#	libs/messaging/messaging-impl/src/test/kotlin/net/corda/messaging/mediator/StateManagerHelperTest.kt
#	libs/messaging/messaging-impl/src/test/kotlin/net/corda/messaging/mediator/processor/ConsumerProcessorTest.kt
ben-millar
ben-millar previously approved these changes Jan 15, 2024
Copy link
Contributor

@ben-millar ben-millar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LWogan LWogan requested a review from ben-millar January 15, 2024 16:08
Copy link
Contributor

@ben-millar ben-millar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gooder to me

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LWogan LWogan merged commit 9938e2b into release/os/5.2 Jan 15, 2024
4 checks passed
@LWogan LWogan deleted the CORE-19282/mediator-wrapper-state branch January 15, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants