CORE-18863: Helm Schema Changes 4 State Isolation #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update json schema changes (Helm only) to support new deployment model on which state types can be isolated and workers are allowed to access more than a single State Manager instance. Changes introduced by this commit are backward compatible with the existing schema, comments were added so that the relevant code can be entirely removed once the new deployment model is fully rolled out.
|
Jenkins build for PR 5476 build 8 Build Successful: |
davidcurrie
requested changes
Jan 22, 2024
|
Thanks for the updates. LGTM pending the additional state Conal has mentioned. |
conalsmith-r3
previously approved these changes
Jan 23, 2024
davidcurrie
reviewed
Jan 23, 2024
|
conalsmith-r3
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update json schema changes (Helm only) to support new deployment model
on which state types can be isolated and workers are allowed to access
more than a single State Manager instance.
Changes introduced by this commit are backward compatible with the
existing schema, comments were added so that the relevant code can be
entirely removed once the new deployment model is fully rolled out.