Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-1992: Replace deprecated methods with recommended usage #98

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

anton-subbotin
Copy link
Contributor

@anton-subbotin anton-subbotin commented Feb 29, 2024

CorDapps code includes Corda API methods which were marked as terminally deprecated since 5.0 GA.
When building CPIs, it results in Deprecated warnings in the IDE console.
This change fixes the warnings by using the recommended methods.
Flows were manually tested following the "Running the Chat CorDapp" from Corda 5 documentation.

@anton-subbotin
Copy link
Contributor Author

anton-subbotin commented Feb 29, 2024

Copy link

@tlawson3 tlawson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-subbotin anton-subbotin marked this pull request as ready for review February 29, 2024 16:55
@anton-subbotin anton-subbotin marked this pull request as draft February 29, 2024 16:55
Copy link
Member

@davidcurrie davidcurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-subbotin anton-subbotin marked this pull request as ready for review February 29, 2024 17:56
Copy link
Contributor

@peterli-r3 peterli-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@anton-subbotin anton-subbotin merged commit b867656 into release-V5.2 Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants