Changed InsufficientBalanceException supertype to CordaRuntimeExcepti…

…on so it gets serialised correctly by Corda
corda · Oct 29, 2020 · 4dd3bd4 · 4dd3bd4
1 parent 617ae82
commit 4dd3bd4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/modules/selection/src/main/kotlin/com.r3.corda.lib.tokens.selection/SelectionUtilities.kt b/modules/selection/src/main/kotlin/com.r3.corda.lib.tokens.selection/SelectionUtilities.kt
@@ -4,6 +4,7 @@ package com.r3.corda.lib.tokens.selection
 import co.paralleluniverse.fibers.Suspendable
 import com.r3.corda.lib.tokens.contracts.internal.schemas.PersistentFungibleToken
 import com.r3.corda.lib.tokens.contracts.types.TokenType
+import net.corda.core.CordaRuntimeException
 import net.corda.core.identity.AbstractParty
 import net.corda.core.identity.Party
 import net.corda.core.node.services.vault.QueryCriteria
@@ -59,7 +60,7 @@ fun tokenAmountWithHolderCriteria(token: TokenType, holder: AbstractParty): Quer
  *
  * @param message The exception message that should be thrown in this context
  */
-open class InsufficientBalanceException(message: String) : RuntimeException(message)
+open class InsufficientBalanceException(message: String) : CordaRuntimeException(message)
 
 /**
  * An exception that is thrown where the specified criteria returns an amount of tokens

diff --git a/...ows/src/integrationTest/kotlin/com/r3/corda/lib/tokens/integrationTest/TokenDriverTest.kt b/...ows/src/integrationTest/kotlin/com/r3/corda/lib/tokens/integrationTest/TokenDriverTest.kt
@@ -1,14 +1,14 @@
 package com.r3.corda.lib.tokens.integrationTest
 
 import com.r3.corda.lib.ci.workflows.RequestKey
-import com.r3.corda.lib.ci.workflows.RequestKeyFlow
 import com.r3.corda.lib.tokens.contracts.states.FungibleToken
 import com.r3.corda.lib.tokens.contracts.states.NonFungibleToken
 import com.r3.corda.lib.tokens.contracts.types.IssuedTokenType
 import com.r3.corda.lib.tokens.contracts.types.TokenType
 import com.r3.corda.lib.tokens.contracts.utilities.*
 import com.r3.corda.lib.tokens.money.GBP
 import com.r3.corda.lib.tokens.money.USD
+import com.r3.corda.lib.tokens.selection.InsufficientNotLockedBalanceException
 import com.r3.corda.lib.tokens.testing.states.House
 import com.r3.corda.lib.tokens.testing.states.Ruble
 import com.r3.corda.lib.tokens.workflows.flows.rpc.ConfidentialIssueTokens
@@ -50,6 +50,7 @@ import org.hamcrest.CoreMatchers.`is`
 import org.hamcrest.CoreMatchers.equalTo
 import org.junit.Assert
 import org.junit.Test
+import kotlin.test.assertFailsWith
 
 class TokenDriverTest {
 
@@ -297,14 +298,14 @@ class TokenDriverTest {
 
             // Restart the node
             val restartedNode = startNode(providedName = DUMMY_BANK_A_NAME, customOverrides = mapOf("p2pAddress" to "localhost:30000")).getOrThrow()
-            // Try to spend same states, they should be locked after restart, so we expect insufficient balance exception to be thrown.
-            assertThatExceptionOfType(CordaRuntimeException::class.java).isThrownBy {
+            // Try to spend same states, they should be locked after restart, so we expect insufficient not locked balance exception to be thrown.
+            assertFailsWith<InsufficientNotLockedBalanceException> {
                 restartedNode.rpc.startFlowDynamic(
-                        SelectAndLockFlow::class.java,
-                        50.GBP,
-                        10.millis
+                    SelectAndLockFlow::class.java,
+                    50.GBP,
+                    10.millis
                 ).returnValue.getOrThrow()
-            }.withMessageContaining("InsufficientBalanceException: Insufficient spendable states identified for 50.00 TokenType(tokenIdentifier='GBP', fractionDigits=2)")
+            }
             // This should just work.
             restartedNode.rpc.startFlowDynamic(
                     SelectAndLockFlow::class.java,