test: check every explicit warnings

package.json

@@ -33,6 +33,7 @@
     "esbuild": "^0.18.20",
     "esbuild-register": "^3.5.0",
     "eslint": "^8.57.0",
+    "mocha": "^9.2.2",
     "shx": "^0.3.4",
     "tsx": "patch:tsx@npm%3A4.7.0#./.yarn/patches/tsx-npm-4.7.0-86d7b66640.patch",
     "typescript": "^5.4.3",

packages/core/tests/fork.spec.ts

@@ -1,5 +1,5 @@
 import { Context } from '../src'
-import { noop } from 'cosmokit'
+import { defineProperty, noop } from 'cosmokit'
 import { expect } from 'chai'
 import { mock } from 'node:test'
 import { event, Filter, Session, filter } from './utils'
@@ -92,6 +92,8 @@ describe('Fork', () => {
   it('deferred execution', () => {
     const root = new Context()
     root.provide('foo')
+    const warning = mock.fn()
+    root.on('internal/warning', warning)
     const listener = mock.fn()
     const callback = mock.fn((ctx: Context) => {
       ctx.on(event, listener)
@@ -105,8 +107,10 @@ describe('Fork', () => {
 
     root.plugin(plugin)
     expect(callback.mock.calls).to.have.length(0)
+    expect(warning.mock.calls).to.have.length(0)
     root.plugin(plugin)
     expect(callback.mock.calls).to.have.length(0)
+    expect(warning.mock.calls).to.have.length(1) // FIXME should be 0 maybe?
     root.emit(event)
     expect(listener.mock.calls).to.have.length(0)
 
@@ -133,7 +137,7 @@ describe('Fork', () => {
 
   it('state.uid', () => {
     const root = new Context()
-    const callback1 = mock.fn()
+    const callback1 = defineProperty(mock.fn(), 'reusable', true)
     expect(root.state.uid).to.equal(0)
 
     const fork1 = root.plugin(callback1)

packages/core/tests/plugin.spec.ts

@@ -36,10 +36,14 @@ describe('Plugin', () => {
   it('apply duplicate plugin', () => {
     const root = new Context()
     const callback = mock.fn()
+    const warning = mock.fn()
+    root.on('internal/warning', warning)
     root.plugin({ apply: callback })
     expect(callback.mock.calls).to.have.length(1)
+    expect(warning.mock.calls).to.have.length(0)
     root.plugin({ apply: callback }) // duplicate
     expect(callback.mock.calls).to.have.length(1)
+    expect(warning.mock.calls).to.have.length(1)
   })
 
   it('apply plugin when dispose', () => {

packages/core/tests/service.spec.ts

@@ -145,17 +145,20 @@ describe('Service', () => {
     }
 
     const root = new Context()
+    const warning = mock.fn()
+    root.on('internal/warning', warning)
     root.plugin(Foo)
     root.foo.increse()
     expect(root.foo.size).to.equal(1)
 
-    const fork = root.plugin((ctx) => {
+    const fork = root.inject(['foo'], (ctx) => {
       ctx.foo.increse()
       expect(ctx.foo.size).to.equal(2)
     })
 
     fork.dispose()
     expect(root.foo.size).to.equal(1)
+    expect(warning.mock.calls).to.have.length(0)
   })
 
   it('dependency update', async () => {

packages/core/tests/status.spec.ts

@@ -7,6 +7,8 @@ describe('Status', () => {
   it('invalid config (main)', async () => {
     const root = new Context()
     const callback = mock.fn()
+    const error = mock.fn()
+    root.on('internal/error', error)
     const apply = mock.fn((ctx: Context) => {
       ctx.on(event, callback)
     })
@@ -19,12 +21,14 @@ describe('Status', () => {
     expect(fork.status).to.equal(ScopeStatus.FAILED)
     expect(fork.runtime.status).to.equal(ScopeStatus.FAILED)
     expect(apply.mock.calls).to.have.length(0)
+    expect(error.mock.calls).to.have.length(1)
 
     fork.update({ foo: true })
     await checkError(root)
     expect(fork.status).to.equal(ScopeStatus.ACTIVE)
     expect(fork.runtime.status).to.equal(ScopeStatus.ACTIVE)
     expect(apply.mock.calls).to.have.length(1)
+    expect(error.mock.calls).to.have.length(1)
 
     root.emit(event)
     expect(callback.mock.calls).to.have.length(1)
@@ -33,6 +37,8 @@ describe('Status', () => {
   it('invalid plugin (fork)', async () => {
     const root = new Context()
     const callback = mock.fn()
+    const error = mock.fn()
+    root.on('internal/error', error)
     const apply = mock.fn((ctx: Context) => {
       ctx.on(event, callback)
     })
@@ -48,6 +54,7 @@ describe('Status', () => {
     expect(fork1.status).to.equal(ScopeStatus.FAILED)
     expect(fork2.status).to.equal(ScopeStatus.ACTIVE)
     expect(apply.mock.calls).to.have.length(1)
+    expect(error.mock.calls).to.have.length(1)
 
     root.emit(event)
     expect(callback.mock.calls).to.have.length(1)
@@ -56,6 +63,8 @@ describe('Status', () => {
   it('plugin error (main)', async () => {
     const root = new Context()
     const callback = mock.fn()
+    const error = mock.fn()
+    root.on('internal/error', error)
     const apply = mock.fn((ctx: Context) => {
       ctx.on(event, callback)
       throw new Error('plugin error')
@@ -66,6 +75,7 @@ describe('Status', () => {
     expect(fork.runtime.status).to.equal(ScopeStatus.FAILED)
     expect(fork.status).to.equal(ScopeStatus.ACTIVE)
     expect(apply.mock.calls).to.have.length(1)
+    expect(error.mock.calls).to.have.length(1)
 
     root.emit(event)
     expect(callback.mock.calls).to.have.length(0)
@@ -74,6 +84,8 @@ describe('Status', () => {
   it('plugin error (fork)', async () => {
     const root = new Context()
     const callback = mock.fn()
+    const error = mock.fn()
+    root.on('internal/error', error)
     const apply = mock.fn((ctx: Context, config: { foo?: boolean } | undefined) => {
       ctx.on(event, callback)
       if (!config?.foo) throw new Error('plugin error')
@@ -85,6 +97,7 @@ describe('Status', () => {
     expect(fork1.status).to.equal(ScopeStatus.FAILED)
     expect(fork2.status).to.equal(ScopeStatus.ACTIVE)
     expect(apply.mock.calls).to.have.length(2)
+    expect(error.mock.calls).to.have.length(1)
 
     root.emit(event)
     expect(callback.mock.calls).to.have.length(1)

packages/core/tests/update.spec.ts

@@ -13,6 +13,9 @@ describe('Update', () => {
   it('update runtime', () => {
     const root = new Context()
     const dispose = mock.fn(noop)
+    const warning = mock.fn(noop)
+    root.on('internal/warning', warning)
+
     const plugin = mock.fn((ctx: Context, config: Config) => {
       ctx.on('dispose', dispose)
       ctx.on(event, () => {
@@ -24,16 +27,19 @@ describe('Update', () => {
 
     root.plugin(plugin, { foo: 1 })
     expect(dispose.mock.calls).to.have.length(0)
+    expect(warning.mock.calls).to.have.length(0)
     expect(plugin.mock.calls).to.have.length(1)
 
     // update config, should trigger reload
     root.emit(event)
     expect(dispose.mock.calls).to.have.length(1)
+    expect(warning.mock.calls).to.have.length(1)
     expect(plugin.mock.calls).to.have.length(2)
 
     // update config, should not trigger reload
     root.emit(event)
     expect(dispose.mock.calls).to.have.length(1)
+    expect(warning.mock.calls).to.have.length(2)
     expect(plugin.mock.calls).to.have.length(2)
 
     expect(plugin.mock.calls[0].arguments[0]).to.equal(plugin.mock.calls[1].arguments[0])

tsconfig.base.json

@@ -1,7 +1,8 @@
 {
   "compilerOptions": {
     "target": "es2022",
-    "module": "nodenext",
+    "module": "esnext",
+    "moduleResolution": "bundler",
     "sourceMap": true,
     "declaration": true,
     "emitDeclarationOnly": true,