fix(core): ignore undefined value in model.format (#66)

cordiverse · Dec 17, 2023 · 618a38e · 618a38e
1 parent 94c401e
commit 618a38e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/packages/core/src/driver.ts b/packages/core/src/driver.ts
@@ -154,7 +154,9 @@ export class Database<S = any> {
     if (primary.some(key => key in update)) {
       throw new TypeError(`cannot modify primary key`)
     }
-    return await sel._action('set', sel.model.format(update)).execute()
+    update = sel.model.format(update)
+    if (Object.keys(update).length === 0) return {}
+    return await sel._action('set', update).execute()
   }
 
   async remove<T extends Keys<S>>(table: T, query: Query<S[T]>): Promise<Driver.WriteResult> {

diff --git a/packages/core/src/model.ts b/packages/core/src/model.ts
@@ -160,6 +160,7 @@ export class Model<S = any> {
     const fields = Object.keys(this.fields)
     Object.entries(source).map(([key, value]) => {
       key = prefix + key
+      if (value === undefined) return
       if (fields.includes(key)) {
         result[key] = this.resolveValue(key, value)
         return

diff --git a/packages/tests/src/update.ts b/packages/tests/src/update.ts
@@ -163,6 +163,14 @@ namespace OrmOperations {
       await expect(database.get('temp2', {})).to.eventually.have.shape(table)
     })
 
+    it('noop', async () => {
+      const table = await setup(database, 'temp2', barTable)
+      await database.set('temp2', {}, {})
+      await expect(database.get('temp2', {})).to.eventually.have.shape(table)
+      await database.set('temp2', {}, { text: undefined })
+      await expect(database.get('temp2', {})).to.eventually.have.shape(table)
+    })
+
     it('using expressions', async () => {
       const table = await setup(database, 'temp2', barTable)
       table[1].num = table[1].id * 2