Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(circular-progress-bar): add timer #1538

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(circular-progress-bar): add timer #1538

wants to merge 6 commits into from

Conversation

fulcanellee
Copy link
Collaborator

@fulcanellee fulcanellee commented Jan 17, 2025 •
edited
Loading

  • В CurcularProgressBar добавлен функционал таймера
  • Добавлен размер 96
  • Добавлена возможно определять цвета заголовка и подзаголовка по отдельности

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9341699

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-circular-progress-bar Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fulcanellee fulcanellee marked this pull request as draft January 17, 2025 11:58
@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Jan 17, 2025 •
edited
Loading

Bundle size report

Entry point Size (minified)
circular-progress-bar/index.js 9 (+1.50 KB🔺)

@coveralls
Copy link

coveralls commented Jan 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13069599046

Details

  • 70 of 72 (97.22%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 82.414%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/circular-progress-bar/src/Component.tsx 28 30 93.33%
Totals Coverage Status
Change from base Build 12988517606: 0.1%
Covered Lines: 10836
Relevant Lines: 12006
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@fulcanellee fulcanellee force-pushed the feat/circular-progress-bar_improvement branch from 86b2695 to 31dcbd6 Compare January 20, 2025 07:45
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@fulcanellee fulcanellee marked this pull request as ready for review January 20, 2025 11:31
@fulcanellee fulcanellee requested a review from Oladii January 20, 2025 11:32
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@fulcanellee fulcanellee force-pushed the feat/circular-progress-bar_improvement branch from 2d70849 to 9341699 Compare January 31, 2025 09:05
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reme3d2y reme3d2y reme3d2y left review comments

@Oladii Oladii Oladii approved these changes

@SiebenSieben SiebenSieben Awaiting requested review from SiebenSieben SiebenSieben is a code owner

@hextion hextion Awaiting requested review from hextion hextion is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fulcanellee @core-ds-bot @coveralls @reme3d2y @Oladii