Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Go modules #3

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Convert to Go modules #3

merged 1 commit into from
Jul 10, 2023

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Jul 10, 2023

  • Remove dep / Gopkg.*
  • Drop inline /vendor data.
  • Cleanup .gitignore
  • Add golangci-lint config/workflow.
  • Enable dependabot.
  • Add Go reference badge.

@SuperQ
Convert to Go modules
77ff896 
* Remove dep / Gopkg.*
* Drop inline /vendor data.
* Cleanup .gitignore
* Add golangci-lint config/workflow.
* Enable dependabot.
* Add Go reference badge.

Signed-off-by: SuperQ <superq@gmail.com>
@johnbelamaric
Copy link
Member

Builds and runs for me. I didn't try it against an actual server but as no changes were made to the main.go I think it's fine.

@johnbelamaric johnbelamaric merged commit f7239aa into master Jul 10, 2023
2 checks passed
@SuperQ
Copy link
Contributor Author

SuperQ commented Jul 11, 2023

Yes, for this change I kept the Go pinning the same as the old Gopkg.toml.

@SuperQ SuperQ deleted the superq/go_mod branch July 11, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongtang yongtang Awaiting requested review from yongtang

@chrisohaver chrisohaver Awaiting requested review from chrisohaver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperQ @johnbelamaric