Upgrade coredns image (#136)

Signed-off-by: Hagai Barel <hagaibarel@gmail.com>
coredns · Aug 14, 2023 · f805699 · f805699
1 parent 0bba9e2
commit f805699
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 15 deletions.
diff --git a/charts/coredns/Chart.yaml b/charts/coredns/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 name: coredns
-version: 1.24.5
-appVersion: 1.10.1
+version: 1.25.0
+appVersion: 1.11.0
 home: https://coredns.io
 icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
 description: CoreDNS is a DNS server that chains plugins and provides Kubernetes DNS Services
@@ -20,5 +20,7 @@ engine: gotpl
 type: application
 annotations:
   artifacthub.io/changes: |
-    - kind: fixed
-      description: Fix wrong namespaceSelector in ServiceMonitor when using custom monitoring namespace
+    - kind: changed
+      description: Upgrade CoreDNS to 1.11.0
+    - kind: removed
+      description: remove the preStopSleep option, the docker image doesn't contain the sleep binary
diff --git a/charts/coredns/README.md b/charts/coredns/README.md
@@ -105,7 +105,6 @@ The command removes all the Kubernetes components associated with the chart and
 | `podDisruptionBudget`                          | Optional PodDisruptionBudget                                                                                                              | {}                                                           |
 | `podAnnotations`                               | Optional Pod only Annotations                                                                                                             | {}                                                           |
 | `terminationGracePeriodSeconds`                | Optional duration in seconds the pod needs to terminate gracefully.                                                                       | 30                                                           |
-| `preStopSleep`                                 | Definition of Kubernetes preStop hook executed before Pod termination                                                                     | {}                                                           |
 | `hpa.enabled`                                  | Enable Hpa autoscaler instead of proportional one                                                                                         | `false`                                                      |
 | `hpa.minReplicas`                              | Hpa minimum number of CoreDNS replicas                                                                                                    | `1`                                                          |
 | `hpa.maxReplicas`                              | Hpa maximum number of CoreDNS replicas                                                                                                    | `2`                                                          |

diff --git a/charts/coredns/templates/deployment.yaml b/charts/coredns/templates/deployment.yaml
@@ -131,12 +131,6 @@ spec:
           successThreshold: {{ .Values.readinessProbe.successThreshold }}
           failureThreshold: {{ .Values.readinessProbe.failureThreshold }}
         {{- end }}
-        {{- if .Values.preStopSleep }}
-        lifecycle:
-          preStop:
-            exec:
-              command: ["/usr/bin/sleep", "{{ .Values.preStopSleep }}"]
-        {{- end }}
 {{- if .Values.securityContext }}
         securityContext:
 {{- toYaml .Values.securityContext | nindent 10 }}

diff --git a/charts/coredns/values.yaml b/charts/coredns/values.yaml
@@ -29,10 +29,6 @@ rollingUpdate:
   maxUnavailable: 1
   maxSurge: 25%
 
-# Under heavy load it takes more that standard time to remove Pod endpoint from a cluster.
-# This will delay termination of our pod by `preStopSleep`. To make sure kube-proxy has
-# enough time to catch up.
-# preStopSleep: 5
 terminationGracePeriodSeconds: 30
 
 podAnnotations: {}