Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove biased annotations from prometheus.service.annotations #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove biased annotations from prometheus.service.annotations #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions charts/coredns/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: coredns
version: 1.29.0
version: 1.29.1
appVersion: 1.11.1
home: https://coredns.io
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
Expand All @@ -20,6 +20,4 @@ type: application
annotations:
artifacthub.io/changes: |
- kind: changed
description: Ignore duplicate strings in the fullname helper template
- kind: removed
description: Removed deprecated "engine: gotpl" from the Chart.yaml
description: prometheus.service.annotations map in the default values.yaml should be blank {}
7 changes: 4 additions & 3 deletions charts/coredns/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ serviceType: "ClusterIP"
prometheus:
service:
enabled: false
annotations:
prometheus.io/scrape: "true"
prometheus.io/port: "9153"
annotations: {}
# annotations:
# prometheus.io/scrape: "true"
# prometheus.io/port: "9153"
monitor:
enabled: false
additionalLabels: {}
Expand Down