Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding selectors and names #168

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

alex-berger
Copy link
Contributor

@alex-berger alex-berger commented May 22, 2024

Why is this pull request needed and what does it do?

This allows adapting to non-standard setups like for example AWS EKS CoreDNS Add-on, which use different labels, selectors and object names. Specifically, it allows

  • overriding of selectors for Deployment, Services, PodDisruptionBudget and ServiceMonitor.
  • overriding the ClusterRole and ClusterRoleBinding names.

This is achieved by introducing the following optional new settings:

Parameter Description Default
service.selector Pod selector {}
deployment.selector Pod selector {}
prometheus.service.selector Pod selector {}
prometheus.monitor.selector Service selector {}
clusterRole.nameOverride ClusterRole name override

The changes are fully backward compatible and one has to explicitly opt-in to override the default behavior.

Which issues (if any) are related?

Checklist:

  • I have bumped the chart version according to versioning.
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

@joshuabaird
Copy link

joshuabaird commented Jun 6, 2024

This would be very helpful for users who are trying to install the helm chart over a "stock" EKS deployment or even a deployment where the managed EKS addon for coredns is being used. @alex-berger could we get this fixed up and ready for review?

alex-berger and others added 3 commits June 7, 2024 22:10
PodDisruptionBudget and ServiceMonitor.

This allows adapting to non-standard setups like for example
AWS EKS CoreDNS Add-on, which use different labels and
selectors.

Signed-off-by: Alexander Berger <alex-berger@gmx.ch>
This allows adapting to non-standard setups like for example
AWS EKS CoreDNS Add-on, which use different names.

Signed-off-by: Alexander Berger <alex-berger@gmx.ch>
Signed-off-by: Alexander Berger <alex-berger@gmx.ch>
@alex-berger
Copy link
Contributor Author

Randomly notifying one of the maintainers for review @mrueg, no urgency or pressure, just would love to make progress on this 😇.

Copy link
Collaborator

@hagaibarel hagaibarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise LGTM

charts/coredns/Chart.yaml Outdated Show resolved Hide resolved
@hagaibarel hagaibarel self-assigned this Jun 13, 2024
Signed-off-by: Alexander Berger <alex-berger@gmx.ch>
@hagaibarel hagaibarel merged commit 42bd58d into coredns:master Jun 13, 2024
2 checks passed
@hagaibarel
Copy link
Collaborator

Thanks @alex-berger !

@joshuabaird
Copy link

Thanks, @alex-berger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants