-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pullSecrets, fix assignment of NET_BIND_SERVICE capability #93
Conversation
Hmmm... the linter complains that I did not bump the version number. Should I do this?
|
The image pull secrets are linked with the serviceaccount see: https://github.com/coredns/helm/blob/master/charts/coredns/templates/serviceaccount-autoscaler.yaml#L26 |
@mrueg Okay, so when I have
|
@mrueg how should we proceed with this PR? |
Hi @firefrei I agree with you that specifying a |
92b3397
to
8beb35e
Compare
rebased and version bumped |
Thanks, looking good, one last thing is to update the changelog, see https://github.com/coredns/helm/blob/master/CONTRIBUTING.md#changelog for instructions on what and how |
Done! I hope I inserted the item at the correct position in in the list :-) |
Signed-off-by: Matthias Frei <mf@frei.media>
…ability. Signed-off-by: Matthias Frei <mf@frei.media>
Signed-off-by: Matthias Frei <mf@frei.media>
Signed-off-by: Matthias Frei <mf@frei.media>
Signed-off-by: Matthias Frei <mf@frei.media>
Signed-off-by: Matthias Frei <mf@frei.media>
Signed-off-by: Matthias Frei <mf@frei.media>
Sorry for the delay, |
I tried to use the helm chart in v1.19.7 on our RKE2-based Kubernetes cluster which has special hardening according to CIS-1.6 implemented. However, the images could not be pulled from our private repo as well as the pods terminated with "operation not permitted".
The reason for these two errors were:
CAP_
prefix.This MR fixes all these issues. It tested the helm chart with these fixes, the pods are now able to start!