add subscription flow #114
Conversation
odarbelaeze
commented
Nov 13, 2024
odarbelaeze
commented
- Refactor signup into a single file
- Refactor login into a single file
- Refactor password reset into one file
- Update caniuse db
- Move Message component into the common folder
- Refactor some extra components into single files
- Move account pages into pages directory
- Update caniuse db
- Wire up the buyflow
- Update configuration
|
Visit the preview URL for this PR (updated for commit f712b5c): https://tos-coreofscience-dev--pr114-add-subscription-flo-8yroe73f.web.app (expires Fri, 27 Dec 2024 00:17:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2386445e99a59089f5d22f1adf74f1d05dc58ace |
There was a problem hiding this comment.
All the comments shared here are non required things, just want to leave them here, so someone takes care of it in the future. I left this approved.
It would be nice to allow subscribing only after the email is verified already, what do you think? There could be a message for those who haven't verified their emails saying something like "please verify your email so you can subscribe", what do you think?
Also, the design for the plans is missing
Do you have plans already to implement the account config? So we can share subscription details to the users there?
functions/main.py
Outdated
| { | ||
| "price_usc": subscription.price_usc, | ||
| "period": subscription.period.value, | ||
| "start_date": subscription.start_date, | ||
| "end_date": end_date, | ||
| "total_price_usc": total_price_usc, | ||
| } |
There was a problem hiding this comment.
How about adding the plan id here, as well as the currency?
Co-authored-by: dani-vh <104392220+dani-vh@users.noreply.github.com>
