Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest MSRV lint test has found some dead_code sections #1085

Open
prestist opened this issue Jun 14, 2024 · 0 comments
Open

Latest MSRV lint test has found some dead_code sections #1085

prestist opened this issue Jun 14, 2024 · 0 comments

Comments

@prestist
Copy link
Contributor

prestist commented Jun 14, 2024

Evaluate if they can be safely removed or continue to be ignored.

cargo clippy --all-targets -- -D warnings
    Checking afterburn v5.5.1 (/home/spresti/workspace/afterburn)
error: fields `fqdn` and `public_keys` are never read
  --> src/providers/ibmcloud_classic/mod.rs:49:9
   |
46 | pub struct MetaDataJSON {
   |            ------------ fields in this struct
...
49 |     pub fqdn: String,
   |         ^^^^
...
57 |     pub public_keys: HashMap<String, String>,
   |         ^^^^^^^^^^^
   |
   = note: `MetaDataJSON` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

error: fields `id` and `kind` are never read
  --> src/providers/ibmcloud_classic/mod.rs:81:9
   |
79 | pub struct NetNetworkJSON {
   |            -------------- fields in this struct
80 |     /// Unique network ID.
81 |     pub id: String,
   |         ^^
...
84 |     pub kind: String,
   |         ^^^^
   |
   = note: `NetNetworkJSON` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

error: field `availability_zone` is never read
  --> src/providers/openstack/configdrive.rs:43:9
   |
39 | pub struct MetadataOpenstackJSON {
   |            --------------------- field in this struct
...
43 |     pub availability_zone: Option<String>,
   |         ^^^^^^^^^^^^^^^^^
   |
   = note: `MetadataOpenstackJSON` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

error: field `fqdn` is never read
  --> src/providers/powervs/mod.rs:47:9
   |
44 | pub struct MetaDataJSON {
   |            ------------ field in this struct
...
47 |     pub fqdn: String,
   |         ^^^^
   |
   = note: `MetaDataJSON` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

error: field `fqdn` is never read
  --> src/providers/ibmcloud_classic/mod.rs:49:9
   |
46 | pub struct MetaDataJSON {
   |            ------------ field in this struct
...
49 |     pub fqdn: String,
   |         ^^^^
   |
   = note: `MetaDataJSON` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

error: could not compile `afterburn` (bin "afterburn") due to 4 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `afterburn` (bin "afterburn" test) due to 3 previous errors
prestist added a commit to prestist/afterburn that referenced this issue Jun 14, 2024
Apprently we have had deadcode which is now being picked up by latest
MSRV lint. Created issue to evaluate it coreos#1085.
prestist added a commit to prestist/afterburn that referenced this issue Jun 14, 2024
Apprently we have had deadcode which is now being picked up by latest
MSRV lint. Created issue to evaluate it coreos#1085.
prestist added a commit to prestist/afterburn that referenced this issue Jun 14, 2024
Apprently we have had deadcode which is now being picked up by latest
MSRV lint. Created issue to evaluate it coreos#1085.
prestist added a commit to prestist/afterburn that referenced this issue Jun 17, 2024
Apprently we have had deadcode which is now being picked up by latest
MSRV lint. Created issue to evaluate it coreos#1085.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant