azure: hardcode fallback for wireserver endpoint #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prep for #130. |
|
I've also verified that this fallback is compatible with our metadata version. |
lucab
reviewed
Jan 14, 2019
If we can't fetch the wireserver address from the DHCP lease option, do what WALinuxAgent does and use the fallback wireserver endpoint at 168.63.129.16.
lucab
approved these changes
Jan 14, 2019
|
@jlebon can you self-merge this here? |
|
Doesn't look like it. |
bgilbert
reviewed
Jan 14, 2019
| @@ -46,6 +46,10 @@ Content-Transfer-Encoding: base64 | |||
|
|
|||
| "; | |||
|
|
|||
| /// This is a known working wireserver endpoint within Azure. | |||
| /// See: https://blogs.msdn.microsoft.com/mast/2015/05/18/what-is-the-ip-address-168-63-129-16/ | |||
| const FALLBACK_WIRESERVER_ADDR: [u8; 4] = [168, 63, 129, 16]; // for grep: 168.63.129.16 | |||
There was a problem hiding this comment.
for grep: 168.63.129.16
💯
There was a problem hiding this comment.
Four years later, I did indeed end up finding this line with grep. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we can't fetch the wireserver address from the DHCP lease option, do
what WALinuxAgent does and use the fallback wireserver endpoint at
168.63.129.16.