providers/azure: fetch hostname from metadata #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP: this is based on quick spec reading. I haven't tested it on a real Azure instance. |
lucab
force-pushed
the
ups/azure-hostname
branch
from
01162e5
to
143df54
Compare
lucab
force-pushed
the
ups/azure-hostname
branch
from
143df54
to
3f048cc
Compare
|
Fixes #197. |
This implements fetching the machine name from Azure metadata. Ref: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/instance-metadata-service
lucab
force-pushed
the
ups/azure-hostname
branch
from
3f048cc
to
57e7023
Compare
|
Double checked the behavior on a real Azure node (standard B1MS), all good. This is ready for review. |
|
/cc @crawford as I think he's writing similar logic. If there are no concerns for conflicts, please feel free to merge. |
|
I hadn't started on my implementation yet, so this is perfect. This approach looks good to me. We'll eventually want to move the rest of the functionality over to the metadata service in order to support Azure Stack. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements fetching the machine name from Azure metadata.
Ref: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/instance-metadata-service
Fixes #197