-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providers: add an AzureStack stub #463
Conversation
Here is an OVF-XML file from AzureStack. You'll notice that today it treats Linux VM's as Windows.
The ISO also includes an
I would need word from Microsoft or API documentation, but the example |
FWIW, I'm am happy to leave this a WIP if the Afterburn overseers would prefer a "complete" provider pending information from MS. |
@darkmuggle thanks for starting this! You noted this is kind of a
/cc @lucab |
In regards to the |
@ashcrow @darkmuggle yes we can add default implementation for trait methods, that would help de-duplicating the same empty logic in a bunch of places. I'm not very convinced about a |
Just for clarity, does the |
Generally in all the providers there are trait(s) that are not implemented or used by the provider; they all had various methods of noop'ing. This change unifies the noop handling implementing the required fn in the trait definition itself.
f5dc89e
to
5bbb630
Compare
TBH, I think that is the case, but I'm not sure. The snippets came via Microsoft. In fact, when I did a deep dive on the XML, I have serious questions about whether it was provisioned as Windows or Linux virtual machine; the ISO contains windows PowerShell commandlets.
Yeah, I've not convinced myself. I was learning me some Rust as my Hack-day, and thought that I would do something potentially useful; hence this PR. After filing the PR, I realized that I'll update the PR to:
|
@darkmuggle did you close this by mistake or in preparation for a further step? |
I was going to rebase and submit as two sperate PRs:
The diff was pretty ugly, IMHO. |
Stub out AzureStack wire-framing in anticipation of working on AzureStack in the near future. This stub out should allow exploration on the AzureStack platform.
As a platform AzureStack does not provide either a meta-data service nor does it provide a useful OVF XML the utility of Afterburn is a pretty much a noop for AzureStack.
Signed-off-by: Ben Howard ben.howard@redhat.com