Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: log a warning on network failure if non-root #469

Merged
merged 1 commit into from
Jul 30, 2020
Merged

azure: log a warning on network failure if non-root #469

merged 1 commit into from
Jul 30, 2020

Conversation

bh7cw
Copy link
Contributor

@bh7cw bh7cw commented Jul 29, 2020

This logs a warning about possible Azure-specific local firewalling if unable to reach Azure endpoints and running as non-root.

Closes: #95

@bh7cw
Copy link
Contributor Author

bh7cw commented Jul 29, 2020

Manually tested on azure, test result is:

[AzureUser@rhel test729]$ ./afterburn --provider azure --attributes /dev/stdout
(omit info)
Jul 29 12:23:21.351 INFO Fetching http://168.63.129.16/?comp=versions: Attempt #11
Jul 29 12:23:51.352 INFO Failed to fetch: error sending request for url (http://168.63.129.16/?comp=versions): operation timed out
Jul 29 12:23:51.352 WARN unable to reach Azure endpoints, please check whether firewall rules are blocking access to them
Error: failed to run
Caused by: fetching metadata from provider
Caused by: failed to get shared configuration: not found

This is now ready for review.
/cc @lucab

lucab
lucab reviewed Jul 29, 2020
View reviewed changes
src/providers/azure/mod.rs Outdated Show resolved Hide resolved
src/providers/azure/mod.rs Outdated Show resolved Hide resolved
src/providers/azure/mod.rs Show resolved Hide resolved
src/providers/azure/mod.rs Show resolved Hide resolved
@bh7cw
azure: log a warning on network failure if non-root
8b0f983 
This logs a warning about possible Azure-specific local firewalling if unable to reach Azure endpoints and running as non-root.

Closes: coreos#95
@bh7cw bh7cw requested a review from lucab July 29, 2020 19:44
@lucab lucab merged commit 532552c into coreos:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucab lucab lucab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure: log a warning on network failure if non-root
2 participants
@bh7cw @lucab