-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KubeVirt platform support #725
Conversation
b146a8b
to
66ea5b8
Compare
/cc @bgilbert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM generally; two tiny nits and a question.
4e503c5
to
3771956
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Also, looks like |
KubeVirt always exposes `instance_id` and `hostname`. Optionally `instance_type`. ssh keys may be provided by the platform matadata. Signed-off-by: Roman Mohr <rmohr@redhat.com>
Hm, neiter |
@bgilbert could you allow CI to run? It may help me with the fmt issue which you raised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, tests seem happy now.
KubeVirt always exposes
instance_id
andhostname
. Optionally sshkeys may be provided by the platform matadata.
xref coreos/fedora-coreos-tracker#1126
Copying the resulting binary in a fcos VM on kubevirt yields this:
For reference the VMI spec used to let kubevirt inject the data:
This part
is responsible for injecting via config-drive metadata the ssh public keys in the secret
my-pub-key
.