Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

Fixed upgrade process for groups/users add #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Oct 9, 2015

/cc @robszumski @marineam @crawford
Fixes issue when it is impossible to add rkt group to custom user after CoreOS upgrade

@kayrus kayrus force-pushed the kayrus/group_user_append branch 4 times, most recently from bef1bd4 to 8b3f519 Compare October 9, 2015 15:13
@marineam
Copy link
Contributor

marineam commented Oct 9, 2015

It looks like these will append a new entry if the one in /etc is modified at all (e.g. setting a password or adding a user to a group). If we want to fix this we should just start migrating to systemd-sysusers instead, the split /etc and /usr scheme was created before systemd-sysusers existed and I didn't want to write a comprehensive tool like sysusers myself.

@antrik
Copy link

antrik commented Nov 5, 2015

This needs some clarification. So the idea is to migrate all users/groups from /usr/share/baselayout/ to sysusers.d? (And consequently also drop the first-run script manually creating /etc/passwd & co.?)

If so, this will require several enhancements to systemd-sysusers, because in order to create all the users currently present in CoreOS, we need to be able to:

  • create users with a login shell different than nologin
  • create users with a primary group different than the user itself
  • create users/groups with mismatching IDs

Otherwise, there is a total of around ten users that cannot be migrated. A partial migration would only make the whole situation even more messy I believe.

Shall we propose the necessary changes to systemd-sysusers?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants