This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Added fleet user and group #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
A fleet user could be paired with a policykit rule to allow fleetd to run as not-root. If that isn't the plan then probably just drop the user part of this for now. |
|
@marineam added policy rule in related PR coreos/coreos-overlay#1579 |
kayrus
force-pushed
the
kayrus/fleet_group
branch
from
640b388
to
1263796
Compare
|
just a note: for some reason tmpfiles doesn't work: Oct 12 17:14:17 localhost systemd-tmpfiles[305]: [baselayout.conf:10] Unknown user '252'. |
|
weird, that seems like a bug. |
kayrus
force-pushed
the
kayrus/fleet_group
branch
from
1263796
to
e133ed1
Compare
|
Moved tmpfiles conf into coreos-overlay repo. |
kayrus
force-pushed
the
kayrus/fleet_group
branch
from
e133ed1
to
3f3faed
Compare
|
can we do this in a sysusers snippet instead? |
kayrus
force-pushed
the
kayrus/fleet_group
branch
from
3f3faed
to
97cabe7
Compare
|
Closed in favor of coreos/coreos-overlay#1579 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @philips @marineam
Not sure if we need to add fleet user. For example we don't use docker user, only docker group. Same for rkt user.