Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

Add udev rules for Azure disks #148

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Add udev rules for Azure disks #148

merged 1 commit into from
Aug 30, 2018

Conversation

r7vme
Copy link
Contributor

@r7vme r7vme commented Aug 30, 2018

Fixes: coreos/bugs#2481

This change allows to use proper Azure disk paths in ignition.

Fixes: coreos/bugs#2481

This change allows to use proper Azure disk paths in ignition.
Copy link
Contributor

@dm0- dm0- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dm0-
Copy link
Contributor

dm0- commented Aug 30, 2018

The linked issue mentions AWS, too. Does this also need to add 90-cloud-storage.rules?

@ajeddeloh
Copy link
Contributor

If we pull in the aws rules we also need to pull in the helper script (which is fine). I'm fine taking this with or without the AWS fix (but leave the bug open if we don't include the AWS rules).

@lucab
Copy link
Contributor

lucab commented Aug 30, 2018

I didn't check if all the utilies needed by the AWS script are in the initramfs. I'd say we land this to unblock @r7vme and then we check if there other bits we should pull in too.

@dm0-
Copy link
Contributor

dm0- commented Aug 30, 2018

Okay, then I'll merge it as is.

@r7vme This also needs to be updated in the coreos-overlay repo to be included in the OS. If you'd like to do it, the process is to take the latest commit ID in bootengine's master branch and update sys-kernel/bootengine in the overlay with it, then bump the symlink's version number. See its Git log for details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants