Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print previous version too when updating #642

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

travier
Copy link
Member

@travier travier commented Apr 16, 2024

Keep current format to avoid having to update Fedora CoreOS tests as well.

Based on: #472
Co-authored-by: Colin Walters walters@verbum.org
Closes: #445

@HuijingHei
Copy link
Member

CI failed looks wired, can see current_grub was defined.

[2024-04-17T11:22:28.105Z] # Previous EFI: grub2-efi-x64-1:2.06-89.fc38.x86_64,shim-x64-15.8-3.x86_64

[2024-04-17T11:22:28.105Z] # Updated EFI: grub2-efi-x64-1:2.06-102.fc38.x86_64,shim-x64-15.8-3.x86_64,test-bootupd-payload-1.0-1.x86_64

[2024-04-17T11:22:28.105Z] # /run/bootupd-source/tests/e2e-update//e2e-update-in-vm.sh: line 71: current_grub: unbound variable

[2024-04-17T11:22:28.105Z] + fatal 'test failed'

[2024-04-17T11:22:28.105Z] + echo error: test failed

Keep current format to avoid having to update Fedora CoreOS tests as
well.

Based on: coreos#472
Co-authored-by: Colin Walters <walters@verbum.org>
Closes: coreos#445
@travier
Copy link
Member Author

travier commented Apr 19, 2024

I've just realized that it's defined on a previous boot so we won't have it set when this runs.

Copy link
Member

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuijingHei HuijingHei merged commit 561305d into coreos:main Apr 22, 2024
9 checks passed
@cgwalters
Copy link
Member

Thanks for doing this!

@travier travier deleted the print-update-from branch April 23, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add extra message about starting point when performing update
3 participants